Don’t Make These Testing Mistakes

Hey, this is Gleb Bakhmutov from cypress.io. Thank you for inviting me. I want to talk about common mistakes people make when writing cypress tests. But first I want to remind that we are still in a climate crisis. Despite COVID's slowdown, we have to act and act now. You can change your life or better, join an organization that fights together. You can join multiple organizations. I recommend both. In this presentation, I'll cover common mistakes in cypress tests. And then I'll talk about something we're trying to do to minimize the number of mistakes by improving our documentation. I'll finish with a discussion of our GitHub repository. You can find the slides online. And if you have questions, please find me on Twitter. Let's start with cypress mistakes. So when people start writing cypress tests, they forget that cypress tests run in the browser. I know it's a simple fact, but it's easy to write something like this, require file system module and then try to read a file. Well, this will never work because the cypress test executes in the browser. You would not be able to execute this code in your application browser code, right? So instead of trying to access the file system and operating system directly from your spec, you want to go through the cypress commands that we provide to access the file system, node code, and your operating system. You can read file, write file, execute any program, or execute node code using task. The task is the most powerful command. That's the one that executes the node code that you write. For example, a very common use case is try to connect to a database. For example, if you want to reset the database before the start of a test. If you write your plugin file like this, it runs in node. You can reuse part of your application code to connect to the database and then, for example, truncate the table on a task. We have very good examples of truncating the database and reseeding it with data in our cypress real-world application. You can see that we are executing the task Dbseed before each test. One little detail that I want to point out. If you look at the spec file names, well, here's an example of api test, and here's an example of a user interface phase. A very common mistake is not picking the right type of a test. If your test is hard to write, hard to maintain, has a lot of boilerplate, well, maybe you picked a wrong type of a test and struggling against Magrain. If you're testing a user flow for a web application, it's an end-to-end test. If you're testing an individual piece of code, like a function or a class, you probably want to write a unit test. If you're trying to test a server and how it responds to a REST or a graphql request, you want to write an api test. If you want to see how a page looks and if it looks the same, or maybe some of the css styling has changed, you don't want to use individual assertions, you want to do a visual test that compares the page or an element pixel by pixel. If you want to test an individual framework component from react or angular component, you want to write a component test. If you want to see how your page behaves in different resolution, you want to run your end-to-end test with a different viewport. If you want to test accessibility, you want to write an accessibility test using a plugin. Finally, if you want to run Node code, not a browser code, but Node code and test it, well, you cannot do it with cypress today, but stay tuned because we are working on a cypress Node test runner. We often see end-to-end tests that are way too short. On the other hand, sometimes we see tests that are way too long. It's kind of a contradiction. You don't want to have too much money or not enough money. But here's an example of a test that is too short. I think this test was written by someone who's used to unit tests where every test just has one assertion. In this case, we're getting an input element and asserting every attribute in a separate test. This is way too short. It's unproductive. We recommend putting all assertions related to that element into a single test. On the other hand, this test is probably way too long. This test goes through multiple fields on multiple pages, filling them up one by one. I believe this test takes way too long to be effective. Imagine if you're working on a feature and you have to make a change in your code and then wait for 30 seconds, a minute, five minutes, just to go through all the steps again and again. You're not very productive. If you split the long tests into smaller ones, you will actually detect the problem faster because when the test fails, you'll know exactly which feature has failed. If you split longer spec files into shorter spec files, then your CI will be able to run those spec files in parallel, speeding up the overall test run. To be honest, the longer the test is, the higher is the chance that the browser will run out of memory and crash. You'll have fewer CI crashes if you use shorter specs. Just remember, when you're writing a cypress test, all commands are asynchronous and also they're all queued to be executed one after another. A very common mistake is to use a local variable like username and then execute visit and find the element. But remember, those commands did not run. They were just queued up. So if you're trying to access that variable immediately, well, guess what? It will still be undefined at this moment. And so the else branch will always run and your if branch never runs. So the right thing is to move all the code that gets the element into the then callback that executes after we visit the page and find the element. Then we can click on the right element, depending on the element's text. I've discussed this question about chaining of commands in our presentations and also our documentation goes into detail and provides a lot of examples of right tests and wrong tests. Another common example when writing end-to-end tests is not having enough assertions. So this is an example of a navigation test. It goes to the home page, finds the link to the about page, clicks on it, confirms we're going to the about page, then clicks on the link to go to the user page. So this is a flow we want to test. And the test seems reasonable. It actually finishes. We are finishing on the user's page. But if we look closely, there are a few red flags. For example, when we click on the about link, cypress command log claims that we clicked on an invisible element. We also seem to have found the user's text before we navigated to the user's page. How is it possible? Well, in this case, we can use the CyPause command and go through the test one by one or use the time-traveling debugger and go over the commands to see what happened and how did the page look at that particular moment. For example, if we're going to the get command that finds the text about on the page, well, we use that command to check that we are on the about page. But look what happened. We accidentally found the text about on the main home page and not on the about page. So we actually passed this test accidentally and for the wrong reason. What we want to do, especially every time we do navigation, is to add assertions. For example, if we're clicking on the about page link, well, our application will do something in response. So before we do another command, we want to assert that that action has finished, that we actually navigated to the about page, and then we want to make sure that the text is there. If we look at the result and we hover over the contains command, well, now we can see that clearly we are on the about page and we find the text that we expect to find. So in general, just like a zebra, try to alternate commands and assertions to make sure that the test runner doesn't run away from the application and in fact does what you expect it to do. When you're adding assertions, you can add positive assertions. For example, trying to find elements and make sure there are two elements found and each has a class completed is a positive assertion. But assertions that start with not keyword, like an element should not have class completed, or the loading element should not be visible, these are called negative assertions. Be careful with negative assertions. It's easy to make a mistake. Here's just one example. Imagine my application is loading data. While it's loading the data, it displays a loading indicator. You write a test that visits a page and then says the loading indicator should not be visible. Well, the test passes. Everything is happy, right? Well, there are a couple of red flags. Look at the negative assertion. The loading indicator is not visible, but it seems to be happening before the AJAX request happens. How is it possible? Well, let's investigate. In my particular application, I can delay loading the data by passing a query parameter. So how does the test look now? Well, the test finishes and then we see the loading of the data. So something is wrong. Our negative assertion passes before the actual event happens. And that's actually correct. Our application doesn't show the loading indicator by default. So our assertion passes immediately, even before we load the data. The solution that I usually recommend is to always have a positive assertion that checks if the action starts before using a negative assertion. In this case, the positive assertion is the loading element should be visible and then it should be invisible. And now it passes. This test is not the best test, actually, because it's flaky. Because the loading indicator is so fast. What we really want to do is to make sure that we slow down the request using the intercept command, and then it's clearly visible, and then it goes away. The biggest mistake, I think, in all of that is that people skip reading documentation. If you're not reading documentation, you're making a mistake. We know that documentation makes or breaks projects. We can see it. Our people tweet, or our users tweet, for example, my organization was evaluating automation framework. I was pushing for playwright, but cypress won due to perceived more available documentation and community support. We won for the right reason, I think. So every time I read our support forum and chat, I feel pain, because I see so many questions, and every time a user has a question, to my opinion, it's a failure of documentation. It probably will be a support issue, or maybe a lost customer for cypress dashboard. We really want our users to find all the questions by themselves. Unfortunately, writing good documentation is hard, because often it's contradictory. Some users need questions answered in different order. For example, first-time visitor might ask, show me Hello World, while repeat user might ask, show me how to do X first. And these demands are contradictory. We optimize our documentation structure for beginners. We put Hello World first, because we think there are 10 beginners for every advanced user. Every advanced user used to be a beginner. And then we add all our documentation to our structure, and we scrape all our documentation, and every answer can be found by search. We even scrape not just our documentation, but our blog posts and our examples, so you can find all the various pieces of information. I even look at the searches with no results, and then I take those searches and I write docs to answer those questions. You don't even have to use the browser to search our documentation. We released an npm module called Cysearch that allows you to search our docs right from your terminal, so you never leave your favorite environment. If you want to know more about the way we structure our documentation and solve this problem, we have a couple of presentations. My personal goal is to have 10 times more cypress examples and recipes than we have right now across all our documentation properties, docs, examples, blog posts, and even videos. The big problem there is to keep examples up to date and correct. There is nothing worse than finding an example, copying it, and then finding out it doesn't work. Here's an example of how we solve it. Imagine there is a question in a chat. How do I toggle a checkbox? I see that question, and I start writing a markdown document where I describe the question and provide html for the mini web application that has it, and then I write my test code in javascript block. Well, we have a markdown preprocessor for cypress that allows us to use markdown files as specs, so we test those examples. Then we push and publish that markdown. It becomes a static documentation page, and then I answer the original question with a link. Of course, those documentation pages have been scraped, and they're available for anyone to find the answer later. So we do not answer support questions directly, especially for private support, because it doesn't scale, because we will have to do it again and again. So instead, we update the documentation, create a new example, or write a blog post, or a recipe, and then answer with a link as you can see in my example. I believe that the support team should really automate their own jobs away, but by writing more docs and more documentation, I mean examples, until all the users can find the answers themselves. So I want to finish with something important. Many people comment on our GitHub issues, and they're angry and frustrated because there are no solutions to their issues. Well, we have a lot of open issues in our repository. Our number of issues every month is tremendous. So for example, in January, we had 300 issues in our repository. We closed 200, but 78 were open. A single 24-hour period shows a lot of activity. Even worse is the number of mentions and comments and updates that happens every day. This is my mailbox, and it shows just emails from cypress.io's cypress repository over maybe about a 30-hour period. There is a lot of activity in our test runner. As you can see, I read most of it. If you have a problem, I suggest you first search our documentation. As I've shown, we put a lot of thought into the docs and searches. If you don't find an answer, please search our GitHub issues. Sometimes the GitHub text search is bad. So what you can do instead is look at the label that starts with topic. We have 60-something topics. Maybe there is a topic that matches your problem, like visibility, cross-origin, local storage, or network. Click on that label and look through the issues. Open and close. Maybe there is an issue already describing your problem. If you don't find an issue that describes your problem, no big deal. Open a new one. We love it. So the most likely scenario for us to fix your problem or provide a walkaround or a solution is for us to be able to reproduce it. If we can run the code and see the problem ourselves, the chances are higher that we'll be able to fix it. Now you can use one of our starter repositories, like cypress Test Tiny or cypress Example Recipes as the basis for your production. Or you can prepare your own repository that we can install and run. Whatever you do, the most important thing is, please, fill the issue template. Sometimes we get the issues where we just see a screenshot or a piece of custom code that says it doesn't work. Doesn't work in what version of cypress, doesn't what you expect to see. Do you see any errors in the console? We have no idea. So please, fill the issue template. One shortcut you can take is to really limit your example to what's really needed to recreate it. So if you don't have a plugin file or the support file, just set them to false. So we know that those things are not important and limit yourself to just reproducible example like that. I want to leave you with the last piece of advice to summarize. In order for you to write good tests without mistakes, please read the documentation. Thank you. I'm Gleb Bakhmutov. Find me online and also find the slides here. Thank you very much. Take care. Hello, everyone. Hey. So what do you think? Were the answers correct for the poll? The answers were absolutely correct. I myself picked the code coverage because I like seeing that green code coverage badge. I thought more people will pick all of above. So this means there's still room to grow for cypress and make it more fun to write tests. Yeah, that coverage is actually, it's not the goal, but it is a nice way of seeing how good you're doing. So at my current job, I was hired to help improve testing and I went from 12 to 80%. That was my job or it was like 17 to 70 something. I don't remember the exact percentages, but that's like, yes, I did a good job. So I hope people also get that satisfaction when their coverage percentage goes up. But people are here to ask questions. So let's go to the first question of the audience. I have a question from Marcus. What would be the advantage of using cypress Node test runner over existing test runners, like an example, Jest? So we were thinking, right? What is your dev experience while writing tests in Node? And I'm not talking about unit tests, like the smallest piece. What if you wanted to test your Express server? Fire it up and then execute requests against it and see what it does. And if there is a crash, what's your debugging experience when a test fails? So we were thinking of doing the same thing that we've done for browser tests. That means have a container where your Node process runs, where you can observe everything. That container can spy on every network request. It can spy on all file system access calls, on our process calls, right? And we'll give you a graphical user interface. So you'll see all your Node tests, just like you see end-to-end tests and all the commands in a test. And then you'll be able to trace back how your code behaves for every step of a test. So this debugging experience, the GUI, the test results, the ability to actually go back to the failing test and not rerun it again, right? Like you do now, but actually being able to understand while fail step by step, that will be different. So that's the added, it's basically developer experience, if I can sum it up like that. Yes. All right. Thank you. Next question is from Elias. Does the use of data tests or test selectors is good? Absolutely. We think so. We recommend putting special data attributes on your elements that you want to select. For example, a button for clicking or text for searching. So we have best practices guide in our documentation, but explains our logic. We think dedicated selectors are easier to understand and kind of give you a hint, Hey, use me for your testing. Don't remove me. Right. Don't accidentally change me like you can do with classes. A lot of people like using cypress testing library that selects by role, by tax, by form input label. We absolutely encourage that as well. If you find you write better tests using cypress testing library, use those selectors as well. Just make sure don't use some weird 10 or deep X path selector. So that's the only thing. Okay. Next question from Artem. Wouldn't network based await be better for ensuring the navigation is finished? Right. So when you write cypress test and you visit a page or you click a button, it navigates to another page. How do you know that it has finished? Right. How does your user know that it's finished? Well, the user probably either sees the URL change, right? That's one way. Another way, the user sees the new page. But either it doesn't carry, but is a network call that happens. No, the user wants to see the update the page. So we'd kind of advise you to observe the page just like the user and know that you finished the page like that. You can observe network calls if you, for example, spying on a data, if you're confirming the deep behavior of your application. But don't make it your primary observation, I would say. So you kind of tie into the ideology of, well, you'd mentioned it, testing library that tests as much as possible like the real user. Yes. Yes. Yeah. Question number three from Artem. Oh, no. That's the one we just had. Sorry. Question from NOF3412. What would be a good pattern to test a bigger user journey, like a shopping experience without checkout? Go through the whole story. Just write the test, uploads the page, picks an item, puts it in the cart, picks another item, puts in the cart, clicks on the cart, assorts number of items is correct, deals with the payment information, shipping information, and then click submit. Now, when you click submit, you don't want that call to actually go to some third party payment gateway. You probably want in your test to intercept that call using our site intercept command and confirm that what's going to the third party is what you actually entered and expect. So you write the full test. But then you start testing all the edge cases. What happens if shipping is incorrect? Then you might bypass and split that long test into parts. Picking items would be one test, but maybe entering shipping information. So start with a simple user journey all the way to the end. Maybe stop outgoing call, confirm it goes out correctly, and that will be a test. Okay. That's the last question we could do. We have no more time. But if you ask the question in the chat and you need that sweet, sweet answer, Gleb will be in his speaker room available. So go down here to the timetable, click on the speaker room, and Gleb will be there shortly. Gleb, I want to thank you a lot for joining us today and hope to see you again soon. Absolutely. Thanks for having me. Happy testing, everyone. Thanks for having me.